-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow jobs to have return values, which get persisted in the DB #103
base: master
Are you sure you want to change the base?
Conversation
@jappeace @ivb-supercede any thoughts on this functionality / feature? Few notes:
|
Yes this maybe usefull for quick n' dirty jobs where you don't want to make a dedicated table for the job to writeout in. Good to see you back :) |
I left supercede, @RiugaBachi may also wish to comment. |
522673f
to
622f1ac
Compare
No objection on my part |
Is there a way you could implement this without breaking existing code? |
I see why this is useful. My team wouldn't necessarily benefit from it, so I could take or leave this change. Any change to the schema of the job table is unfortunate. However adding a new optional column is about as low impact as you can get. I would appreciate a non-breaking release before any breaking change. We've been using a |
@jappeace @tfausak one way to not break any existing code would be to have a build-time flag along with liberal use of CPP at the following places:
is there any other way to do this? and if CPP is the only way, when do we get finally get rid of the CPP? |
I was thinking along the lines of: instead of changing this function in place, we add a new one and see if it can be made compatable, I'd not go the CPP/flag route as that incurs a rather troublsome maintenance burden and rather do the breakage. |
@jappeace I think two versions of functions can still be dealt with, but what do you think about the Does anyone use the |
I think the two DB columns that all users of the library are going to be forced to create are a greater problem than the Haskell code.... any ideas on how to tackle this? |
(lots of refactoring after rebasing)
57142ff
to
590f277
Compare
No description provided.